Ticket #940 (closed defect: duplicate)

Opened 3 years ago

Last modified 3 years ago

_remake_table does not set NULL or NOT NULL on _south_new_<table> using sqlite3

Reported by: alej0varas@… Owned by: andrew
Priority: major Milestone: 1.0
Component: commands Version: 0.7.3
Keywords: sqlite3 _remake_table null Cc: alej0varas@…

Description

When _remake_table create the schema(definitions) for the _south_new_<table> it does not take in account the 'null_ok' parameter, for this the new table does not represents the real field parameter 'null'.

I've used this to solve the problem, on sqlite3.py at line 73:

definitions[name] = type + [' NOT', ''][column_info[-1]] + ' NULL'

This worked for me, but I'm not sure if it is a safe solution.

Change History

comment:1 Changed 3 years ago by andrew

  • Status changed from new to infoneeded
  • Milestone set to 1.0

Could you retest using the development version of South? There have been several fixes to NULL handling.

comment:2 Changed 3 years ago by alej0varas@…

  • Status changed from infoneeded to assigned

Yes, using development fix the issue. I also noticed that this bug is a duplicated of #700.

comment:3 Changed 3 years ago by andrew

  • Status changed from assigned to closed
  • Resolution set to duplicate
Note: See TracTickets for help on using tickets.