Modify ↓

Ticket #457 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

South unconditionally loads tagging

Reported by: patrys@… Owned by: andrew
Priority: major Milestone: 0.7.1
Component: commands Version: mercurial
Keywords: Cc:

Description

In the tagging introspection plugin:

try:
    from tagging.fields import TagField
except ImportError:
    pass

This of course does not check if the application is installed at all. Just that you have it in your Python path. tagging.fields in turn imports tagging.models thus registering the models while there are no tables in the database.

geodjango handles this nicely by checking INSTALLED_APPS.

Attachments

south-tagging.patch​ (527 bytes) - added by patrys@… 3 years ago.
Proposed patch

Change History

Changed 3 years ago by patrys@…

Proposed patch

comment:1 Changed 3 years ago by andrew

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone set to 0.7.1

Implemented in [e9f852711b12], with a slightly different approach (I don't want South to be the thing to crash if you have a weird INSTALLED_APPS)

View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.