Modify ↓
Ticket #383 (closed defect: fixed)
altering sqlite columns creates invalid sql
| Reported by: | alex@… | Owned by: | andrew |
|---|---|---|---|
| Priority: | major | Milestone: | 0.7 |
| Component: | commands | Version: | 0.7-pre |
| Keywords: | Cc: |
Description
the column name for altered columns was duplicated. for example:
{{{{
south execute "CREATE TABLE "_south_new_market_entry" ("used" bool, "description" text, "title" varchar(200), "image" image, "changed" datetime, "plz" integer, "id" integer PRIMARY KEY, "reminder_sent" bool, "cost" "cost" decimal NOT NULL, "location" varchar(200), "published" datetime, "customer_id" integer, "slug" varchar(50), "vat" bool, "category_id" integer)" with params "[]"
}}}}
see colum "cost". the problem is in _remake_table: altered contains the name, type doesn't. proposed patch is attached.
Attachments
Change History
Changed 3 years ago by Alexander Clausen <alex@…>
- Attachment south-sqlite-alter-column-2.patch added
sorry, first patch was broken
Changed 3 years ago by Alexander Clausen <alex@…>
- Attachment south-sqlite-alter-column-3.patch added
renames where broken by the patch, fix it
comment:1 Changed 3 years ago by andrew
- Status changed from new to closed
- Resolution set to fixed
- Milestone set to 0.7
Fixed in [eb5a5f86d57a].
Note: See
TracTickets for help on using
tickets.
