Modify ↓

Ticket #382 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

sqlite table recreation: not enough quoting

Reported by: alex@… Owned by: andrew
Priority: major Milestone: 0.7
Component: commands Version: 0.7-pre
Keywords: Cc:

Description

If you model has a field with a reversed name, copying data from the temporary table into the new table fails, because the field names are not quoted.

Attachments

south-sqlite-quote-field-names.patch​ (459 bytes) - added by alex@… 3 years ago.
south-sqlite-quote-field-names-2.patch​ (1.1 KB) - added by Alexander Clausen <alex@…> 3 years ago.

Change History

Changed 3 years ago by alex@…

comment:1 Changed 3 years ago by anonymous

ok, somehow, _again_, I managed to mess up my hg checkout. ignore this.

comment:2 Changed 3 years ago by Alexander Clausen <alex@…>

actually, the bug is still valid (the patch is not). in _copy_data, the field names in q_fields (and in field_renames!) are not quoted.

Changed 3 years ago by Alexander Clausen <alex@…>

comment:3 Changed 3 years ago by andrew

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone set to 0.7

Thanks for that; committed in [fb7089894e4d].

View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.