Modify

Ticket #261 (closed defect: fixed)

Opened 5 years ago

Last modified 3 years ago

Need sanity check for default creation on mysql text fields (removed on 503:06124b89deee)

Reported by: anonymous Owned by: andrew
Priority: major Milestone: 0.6.2
Component: commands Version: 0.6
Keywords: Cc:

Description

~/south/db/generic.py

  • 439 elif (not field.null and field.blank) or field.get_default() == :

+ 439 elif (not field.null and field.blank) or (field.get_default() == not getattr(field, '_suppress_default', True)):

Attachments

Change History

comment:1 Changed 5 years ago by andrew

  • Status changed from new to assigned
  • Milestone set to 0.6.2

The patch doesn't make any sense; (field.get_default() == '' not getattr(field,... isn't valid Python...

comment:2 Changed 5 years ago by stefanfoulis

comment:3 Changed 5 years ago by stefanfoulis

I just ran the south tests with the mysql backend... no errors. (I don't know if the altered functionality is actually tested)

comment:4 Changed 5 years ago by andrew

  • Status changed from assigned to closed
  • Resolution set to fixed

I've added in the new test [a4b2ea966ff9] and fixed it completely, hopefully [8f37b45fdee7]. Closing.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.