Ticket #1227 (closed defect: fixed)

Opened 21 months ago

Last modified 14 months ago

Fix deprecated @@storage_engine usage which halts MySQL migration

Reported by: jzempel@… Owned by: andrew
Priority: major Milestone:
Component: commands Version: 0.7.6
Keywords: Cc:

Description

_mysql_exceptions.Warning: '@@storage_engine' is deprecated and will be removed in a future release. Please use '@@default_storage_engine' instead

South-0.7.6-py2.6.egg/south/db/mysql.py", line 179, in connection_init

cursor.execute("SET storage_engine=%s;" % self._get_setting('STORAGE_ENGINE'))

MySQL version is 5.6.10. The line should be:

cursor.execute("SET default_storage_engine=%s;" % self._get_setting('STORAGE_ENGINE'))

Change History

comment:1 Changed 16 months ago by anonymous

I've run into this issue several times. Why isn't it fixed in the repos yet? It's looks like an easy fix. Only problem could be backwards compatibility, but then I imagen breaking backwards compatibility is less of a problem then having code that doesn't work at all with the current version of MySQL.

Of course, it's only a warning in MySQL, but it halts MySQL migrations. So either we should ignore this warning or use default_storage_engine instead of storage_engine.

comment:2 Changed 16 months ago by andrew

  • Status changed from new to infoneeded

Backwards compatability reasons. A lot of people on MySQL are there because they haven't upgraded to something else, and so there's plenty of old versions in the wild.

If someone can give me a precise version spec of what appears where along with numbers of who is using which version, or a patch that does version detection, I'll fix it.

comment:3 Changed 14 months ago by Matthew Tretter <m@…>

  • Status changed from infoneeded to assigned

I've opened a pull request for this issue on Bitbucket.

comment:4 Changed 14 months ago by andrew

  • Status changed from assigned to closed
  • Resolution set to fixed

Closed due to pull request being merged. Thanks!

comment:5 Changed 14 months ago by Matthew Tretter <m@…>

Thank you!

Note: See TracTickets for help on using tickets.