Ticket #1105 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Extraneous '' in Line 113 of base.py Causes Issues

Reported by: anonymous Owned by: andrew
Priority: major Milestone: 1.0
Component: commands Version: unknown
Keywords: Cc:


Line 113 (in v1.7.3 at least) of South's base.py is this:
module = import(module_path, {}, {}, [])

The problem with that line of code is explained here:
and (explained better) here:

The short version is:
"Using the fromlist=[] hack to import a specific module is explicitly frowned upon by python-dev"

If you simply remove the , everything will continue to work, and you will fix a double-importing problem that hits some users (like myself).

Change History

comment:1 Changed 3 years ago by anonymous

Gah, formatting ate my post; that's supposed to read:

"The short version is: Using the fromlist *equals list with empty string* hack ...


"If you simply remove the *empty string*, everything will ...

comment:2 Changed 3 years ago by anonymous

P.S. This same issue applies to several later lines as well

comment:3 Changed 3 years ago by andrew

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone set to 1.0

Fixed in [71ec42bae7fe].

Note: See TracTickets for help on using tickets.